Skip to content

[master] Move SwiftSyntax to its own repository #19061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2018

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 30, 2018

This PR sets up the infrastructure to build SwiftSyntax from its own repository. For this it does:

  • Add the new swift-syntax repository to update-checkout
  • Add a build-script option to build and test swift-syntax
  • Update the build presets to test SwiftSyntax when running @swift-ci Please test
  • Remove SwiftSyntax from this repository

@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

@swift-ci Please test

Copy link
Contributor

@harlanhaskins harlanhaskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending passing on CI.

This shouldn’t break folks who haven’t cloned swift-syntax, right? They just won’t pass —build-swiftsyntax

@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

The flag to pass to build-script is --swiftsyntax but yeah, that should be the case. I'll double check locally.

Update: Confirmed that everything works if swift-syntax is not checked out and --swiftsyntax is not passed to build-script.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 66a56b386f737adf50b73fc9c5b9f2394ec966e8

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 66a56b386f737adf50b73fc9c5b9f2394ec966e8

@ahoppen ahoppen force-pushed the swiftsyntax-new-repo branch from 06d685c to 16724ee Compare August 30, 2018 04:10
@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 66a56b386f737adf50b73fc9c5b9f2394ec966e8

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 66a56b386f737adf50b73fc9c5b9f2394ec966e8

@slavapestov
Copy link
Contributor

What's the rationale for moving it out? Are we still going to build it in CI?

@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

We are still going to build it as part of CI if you do @swift-ci Please test.

There are multiple reasons to move this out:

  • If it is a SwiftPM project, people can depend on it while still using the default Xcode toolchain which doesn't include SwiftSyntax.
  • SwiftSyntax can now depend on corelibs-foundation which will make it a lot easier to port to Linux. Otherwise the compiler project would have needed to depend on Foundation which was not desirable.
  • The package should be more discoverable and have a lower burden to contribute to this way.
  • If the development is a little bit more separate from the compiler we should be able to accept minor improvements to the Swift side more easily that would otherwise be blocked by a locked down release branch.

@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

Fixed the issue that caused this in the swift-syntax repo.

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 16724eee9efe58340bc7bdcdc67c81184291deee

@shahmishal
Copy link
Member

@swift-ci build toolchain

@shahmishal
Copy link
Member

@swift-ci Please Build Toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 16724eee9efe58340bc7bdcdc67c81184291deee

Install command
tar zxf swift-PR-19061-48-ubuntu16.04.tar.gz
More info

@ahoppen ahoppen force-pushed the swiftsyntax-new-repo branch from 16724ee to 3709431 Compare August 30, 2018 18:52
@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 16724eee9efe58340bc7bdcdc67c81184291deee

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 16724eee9efe58340bc7bdcdc67c81184291deee

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 16724eee9efe58340bc7bdcdc67c81184291deee

Install command
tar -zxf swift-PR-19061-62-osx.tar.gz --directory ~/

@shahmishal shahmishal merged commit 76aa3ed into swiftlang:master Aug 30, 2018
@ahoppen ahoppen deleted the swiftsyntax-new-repo branch October 21, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants