Skip to content

[4.2] Move SwiftSyntax to its own repository #19064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2018
Merged

[4.2] Move SwiftSyntax to its own repository #19064

merged 2 commits into from
Aug 30, 2018

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 30, 2018

This PR sets up the infrastructure to build SwiftSyntax from its own repository for the swift-4.2-branch. For this it does:

  • Add the new swift-syntax repository to update-checkout
  • Add a build-script option to build and test swift-syntax
  • Update the build presets to test SwiftSyntax when running @swift-ci Please test

Removing SwiftSyntax from the swift-4.2-branch of this repository will be done in a separate PR.

@ahoppen ahoppen requested review from akyrtzi and shahmishal August 30, 2018 02:10
@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 59afe38451b19341da5f2287b5c7933639fa53f3

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 59afe38451b19341da5f2287b5c7933639fa53f3

@ahoppen ahoppen force-pushed the swiftsyntax-new-repo-4.2 branch 2 times, most recently from 6ec0293 to 3a8a26d Compare August 30, 2018 04:11
@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 59afe38451b19341da5f2287b5c7933639fa53f3

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 59afe38451b19341da5f2287b5c7933639fa53f3

@ahoppen ahoppen force-pushed the swiftsyntax-new-repo-4.2 branch from 3a8a26d to 640e8fe Compare August 30, 2018 18:14
@akyrtzi
Copy link
Contributor

akyrtzi commented Aug 30, 2018

For anyone else reading this, we've decided against removing SwiftSyntax from swift-4.2-branch. It won't affect things and we want to make swift-4.2-branch changes as minimum as possible.

@ahoppen ahoppen force-pushed the swiftsyntax-new-repo-4.2 branch from 640e8fe to 13c41af Compare August 30, 2018 18:43
@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 3a8a26d5c1384445cb62e5d6b7cd04d5e11aaa38

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 3a8a26d5c1384445cb62e5d6b7cd04d5e11aaa38

@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

@swift-ci Please build toolchain

@ahoppen
Copy link
Member Author

ahoppen commented Aug 30, 2018

@swift-ci Please Build Toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 13c41af

Install command
tar zxf swift-PR-19064-50-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 13c41af

Install command
tar -zxf swift-PR-19064-64-osx.tar.gz --directory ~/

@shahmishal shahmishal merged commit 6598f91 into swiftlang:swift-4.2-branch Aug 30, 2018
@ahoppen ahoppen deleted the swiftsyntax-new-repo-4.2 branch October 21, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahoppen @swift-ci @akyrtzi @shahmishal