[ConstraintSystem] NFC: Move allowFreeTypeVariableBindings into `So…
#19101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @rudkx Any objections? |
rudkx
reviewed
Sep 1, 2018
…lverState` Currently `allowFreeTypeVariableBindings` flag has to be passed all the way down from top-level `solve` call to `finalize` that forms (partial and complete) solutions. Instead of doing that, let's just make it a part of the solver state, which is already present throughout whole solver run.
xedin
force-pushed
the
move-allow-free-typevars-into-state
branch
from
a01d9c4 to
d560b36
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lverState`
Currently
allowFreeTypeVariableBindingsflag has to be passed allthe way down from top-level
solvecall tofinalizethat forms(partial and complete) solutions. Instead of doing that, let's just
make it a part of the solver state, which is already present
throughout whole solver run.