[ConstraintSystem] NFC: Unify type variable and disjunction choice re… #19117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rudkx I have renamed both type variable and disjunction choice generators into producers and unified their interface to use |
…presentation Introduce `TypeBinding` interface with a single `attempt` method which is useful to encapsulate specific binding logic used for attempting disjunction choices and type variable bindings under a single interface. This makes it easier to unify top-level logic responsible for binding enumeration. It should also make it possible to introduce unified binding producer interface in the future.
xedin
force-pushed
the
introduce-type-binding
branch
from
d42c1fa to
e5b63fa
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…presentation
Introduce
TypeBindinginterface with a singleattemptmethodwhich is useful to encapsulate specific binding logic used for
attempting disjunction choices and type variable bindings under
a single interface. This makes it easier to unify top-level logic
responsible for binding enumeration.
It should also make it possible to introduce unified binding producer
interface in the future.