SILOptimizer: handle copies in LetPropertiesOpt. #19120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing an alloc_stack of a struct/tuple with multiple alloc_stacks of the struct/tuple elements should only be done if the elements are somehow accessed individually. If not, e.g. if the whole struct/tuple is just copied, there is no benefit of doing SROA. Although this change has little impact by its own (some small code size wins), it is important for the improvement of let-property optimization.
When the initializer of a property is analyzed we now don't bail if such a property is copied from another instance of a struct/class. This fixes a strange performance regression with constant let properties in structs which conform to an unrelated protocol. SR-7713 rdar://problem/40332203
|
@swift-ci test |
|
@swift-ci benchmark |
Build comment file:Performance: -O
Code size: -O
Performance: -Osize
Code size: -Osize
Performance: -Onone
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR. Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein). Hardware Overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the initializer of a property is analyzed we now don't bail if such a property is copied from another instance of a struct/class.
This fixes a strange performance regression with constant let properties in structs which conform to an unrelated protocol.
This PR also includes a required improvement in SROA: only do SROA when it has a benefit.
SR-7713
rdar://problem/40332203