Skip to content

[sil] Eliminate the src parameter from end_borrow. #19124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Sep 4, 2018

This does not eliminate the entrypoints on SILBuilder yet. I want to do this in
two parts so that it is functionally easier to disentangle changing the APIs
above SILBuilder and changing the underlying instruction itself.

rdar://33440767

@gottesmm gottesmm requested a review from atrick September 4, 2018 20:12
@gottesmm
Copy link
Contributor Author

gottesmm commented Sep 4, 2018

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Sep 4, 2018

Build failed
Swift Test Linux Platform
Git Sha - cf1ad152f961f743bd33006fff40da7c72c2cff6

@swift-ci
Copy link
Contributor

swift-ci commented Sep 4, 2018

Build failed
Swift Test OS X Platform
Git Sha - cf1ad152f961f743bd33006fff40da7c72c2cff6

@gottesmm gottesmm force-pushed the pr-1b720840e87378cbb83b63318c7de75740a7b080 branch from cf1ad15 to 0504b6d Compare September 4, 2018 23:21
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This does not eliminate the entrypoints on SILBuilder yet. I want to do this in
two parts so that it is functionally easier to disentangle changing the APIs
above SILBuilder and changing the underlying instruction itself.

rdar://33440767
@gottesmm gottesmm force-pushed the pr-1b720840e87378cbb83b63318c7de75740a7b080 branch from 0504b6d to c599539 Compare September 4, 2018 23:38
@gottesmm
Copy link
Contributor Author

gottesmm commented Sep 4, 2018

@swift-ci test

3 similar comments
@gottesmm
Copy link
Contributor Author

gottesmm commented Sep 4, 2018

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Sep 4, 2018

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Sep 4, 2018

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Sep 4, 2018

Build failed
Swift Test Linux Platform
Git Sha - cf1ad152f961f743bd33006fff40da7c72c2cff6

@gottesmm gottesmm merged commit fee237e into swiftlang:master Sep 5, 2018
@gottesmm gottesmm deleted the pr-1b720840e87378cbb83b63318c7de75740a7b080 branch September 5, 2018 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants