[PrintAsObjC] Use 'unsafe_unretained' to print 'unowned', not 'assign' #19167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please test macOS |
rjmccall
reviewed
Sep 10, 2018
lib/PrintAsObjC/PrintAsObjC.cpp
Outdated
| // We treat "unowned" as "unsafe_unretained" (even though it's more like | ||
| // "safe_unretained") because we want people to think twice about | ||
| // allowing that object to disappear. "unowned(unsafe)" (and Unmanaged, | ||
| // handled below) really are "unsafe_unretained". |
There was a problem hiding this comment.
Can this reasonably be turned into an exhaustive switch over reference storage kinds?
rjmccall
approved these changes
Sep 10, 2018
The ObjC generator previously preserved a subtle difference between 'unowned' and 'unowned(unsafe)' / Unmanaged by printing the former as 'assign' and the latter as 'unsafe_unretained'. Upstream Clang, however, has gotten a new warning to discourage the use of 'assign' with reference-countable types at all. Since it was always a subtle distinction, just go with the new convention and print 'unsafe_unretained' for 'unowned' properties as well. rdar://problem/44290715
Exhaustively switch over reference types, so that we'll know if any new ones are added, and factor out a repeated check to see if something's a retainable object type. No functionality change.
jrose-apple
force-pushed
the
proper-property-properties
branch
from
a0e711b to
340090c
Compare
|
Good suggestion, spotted another reasonable cleanup while I was doing that. @swift-ci Please smoke test |
bob-wilson
added a commit
that referenced
this pull request
Feb 15, 2019
…type The issue was fixed in #19167 so we no longer need to disable this warning. rdar://problem/47777548
bob-wilson
added a commit
that referenced
this pull request
Feb 15, 2019
…type The issue was fixed in #19167 so we no longer need to disable this warning. rdar://problem/47777548
bob-wilson
added a commit
that referenced
this pull request
Feb 17, 2019
…type The issue was fixed in #19167 so we no longer need to disable this warning. rdar://problem/47777548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ObjC generator previously preserved a subtle difference between
unownedandunowned(unsafe)/ Unmanaged by printing the former asassignand the latter asunsafe_unretained. Upstream Clang, however, has gotten a new warning to discourage the use ofassignwith reference-countable types at all. Since it was always a subtle distinction, just go with the new convention and printunsafe_unretainedforunownedproperties as well.rdar://problem/44290715