Skip to content

Store ProtocolDecl rather than TypeLoc for designated protocol. #19202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2018
Merged

Store ProtocolDecl rather than TypeLoc for designated protocol. #19202

merged 1 commit into from
Sep 10, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Sep 8, 2018

No description provided.

@rudkx rudkx requested a review from jrose-apple September 8, 2018 01:25
@rudkx
Copy link
Contributor Author

rudkx commented Sep 8, 2018

@swift-ci Please smoke test

@rudkx
Copy link
Contributor Author

rudkx commented Sep 8, 2018 

20:56:42 /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/lldb/unittests/Disassembler/TestArmv7Disassembly.cpp:70: Failure
20:56:42 Expected: (nullptr) != (disass_sp.get()), actual: 8-byte object <00-00 00-00 00-00 00-00> vs NULL

@rudkx
Copy link
Contributor Author

rudkx commented Sep 8, 2018

@swift-ci Please smoke test

@rudkx rudkx mentioned this pull request Sep 8, 2018
Merged
@rudkx
Copy link
Contributor Author

rudkx commented Sep 10, 2018

@swift-ci Please smoke test OS X platform

@rudkx rudkx mentioned this pull request Sep 10, 2018
Merged
jrose-apple
jrose-apple approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this definitely seems like a useful step.

@rudkx rudkx merged commit 24b61b3 into swiftlang:master Sep 10, 2018
@rudkx rudkx deleted the rework-type-checking-designated-protocol branch September 10, 2018 18:23
@rudkx rudkx restored the rework-type-checking-designated-protocol branch September 10, 2018 20:16
@rudkx rudkx deleted the rework-type-checking-designated-protocol branch September 10, 2018 20:16
@rudkx rudkx restored the rework-type-checking-designated-protocol branch September 10, 2018 20:16
@rudkx rudkx mentioned this pull request Sep 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudkx @jrose-apple