Skip to content

Reflection: Update extra inhabitants logic for structs. #19254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Sep 11, 2018

Structs now use extra inhabitants from whichever field has the most, not only the first field. rdar://problem/44239246

@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter
Copy link
Contributor Author

cc @milseman

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 68e60dd51d645d767b3898da76f3e8978e46aeef

Structs now use extra inhabitants from whichever field has the most, not only the first field. rdar://problem/44239246
@jckarter jckarter force-pushed the reflection-extra-inhabitants branch from 68e60dd to d249725 Compare September 11, 2018 23:51
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 68e60dd51d645d767b3898da76f3e8978e46aeef

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 68e60dd51d645d767b3898da76f3e8978e46aeef

@jckarter
Copy link
Contributor Author

@swift-ci Please test Linux

@jckarter jckarter merged commit 139c1e5 into swiftlang:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants