[Batch Mode] Very simple and safe fix for batch mode diagnostic suppression bug. Includes tests. #19261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Looks good to me. We should also put the tests in master! |
|
@swift-ci please nominate |
|
I'll put the tests into master. |
|
Build failed |
jrose-apple
reviewed
Sep 12, 2018
| // Verify that -Wno-* options are applied. | ||
| // RUN: %empty-directory(%t) | ||
|
|
||
| // RUN: %target-swift-frontend -module-cache-path %t -enable-objc-interop -typecheck %s -F %S/Inputs/frameworks -Xcc -Wno-#warnings 2>&1 | %FileCheck -check-prefix CHECK-NO-WARN -allow-empty %s | ||
|
|
||
| // XFAIL: linux |
There was a problem hiding this comment.
Oops. Because I changed the test to explicitly pass -enable-objc-interop, it'll pass on Linux now too.
There was a problem hiding this comment.
Ah! That explains it. Thanks.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
davidungar
deleted the
rdar-43438753-and-43033749-fix-batch-mode-no-diags-swift-4.2-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A much smaller and safer fix for the batch mode bug where all diagnostic outputs could be truncated, leaving the user with no diagnostics.
Scope of issue: User gets no diagnostics when all errors are present in non-primaries, e.g. an Objective-C module import error.
Origination: Initial implementation of batch mode.
Risk: Very very small. Adds one flag, set in one place, tested in one place right where the bad behavior would otherwise occur.
Reviewed by: Jordan Rose informally, will get a formal review from him.
Testing: Normal regression tests.
Radar: rdar://43033749, clone of rdar://42314665.
rdar://44362180