Skip to content

[test/lit.cfg] Use absolute imports #19274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Sep 12, 2018

This fixes an issue when using Docker on OSX, 'import shutil' in 'lit.cfg' ends up finding lit.ShUtil instead of the module from the standard library.
Switching to absolute imports ensures that the module from the standard library will be used.

This fixes an issue when using Docker on OSX, 'import shutil' in 'lit.cfg' ends up finding lit.ShUtil instead of the module from the standard library.
Switching to absolute imports ensures that the module from the standard library will be used.
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Sep 12, 2018

@swift-ci smoke test

@akyrtzi akyrtzi merged commit d40a182 into swiftlang:master Sep 12, 2018
@akyrtzi akyrtzi deleted the lit-absolute-import branch September 12, 2018 19:50
@jrose-apple
Copy link
Contributor

Aha, clever! Much nicer than having to set up a case-sensitive partition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants