SILOptimizer: use LLVM_ATTRIBUTE_USED
#19276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @gottesmm |
|
@swift-ci please test and merge |
|
Wouldn't you want to use |
|
Harlan is correct. I've cancelled the merge. |
|
Ugh, yes, that is a typo. @jrose-apple - woah, how do you do that? And thank you for preventing the merge! |
This makes the use of the used attribute more portable. `__attribute__((__used__))` is not accepted by Visual Studio, but LLVM conveniently provides the helpful macro `LLVM_ATTRIBUTE_USED` to enable this.
compnerd
force-pushed
the
unused-portability
branch
from
29518b3 to
99bb383
Compare
compnerd
changed the title
LLVM_ATTRIBUTE_UNUSEDLLVM_ATTRIBUTE_USED
|
@swift-ci please test and merge |
|
Unfortunately it's not a delegatable power—it requires logging into ci.swift.org with an Apple-internal ID. I'll check to see if we have a bug to get a swift-ci command for it. |
|
@swift-ci please test and merge |
|
Filed SR-8734. |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the use of the unused attribute more portable.
__attribute__((__unused__))is not accepted by Visual Studio, but LLVMconveniently provides the helpful macro
LLVM_ATTRIBUTE_UNUSEDto enable this.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.