stdlib: adjust the shims for MSVC mode compilation #19277
Conversation
The SwiftStdint.h header is used in the compiler as well. The compiler may be
built with cl (Visual Studio) on Windows, which does not define
`__INTPTR_TYPE__` nor does it define `__INTPTR_WIDTH__`. Simply define the
`__swift_{,u}intptr_t` typedefs as Microsoft does on that platform when building
with Visual Studio.
|
CC: @gparker42 |
|
@swift-ci please test |
|
cc @mikeash This doesn't seem correct to me. The runtime is always supposed to be compiled with the just-built Clang, not the system compiler, so that it can use swiftcc on platforms that support it. |
|
There's a |
|
@jrose-apple I saw bits of this being included indirectly into the compiler. Unfortunately, I don't have the include path off hand. The runtime currently requires clang to build since we use special calling conventions in the runtime, so |
|
@mikeash - okay to merge then? Is there a better way to accommodate this? |
Upon further inspection, seems that we're ahead of me: |
|
Seems like the right way to fix this to me. |
The SwiftStdint.h header is used in the compiler as well. The compiler may be
built with cl (Visual Studio) on Windows, which does not define
__INTPTR_TYPE__nor does it define__INTPTR_WIDTH__. Simply define the__swift_{,u}intptr_ttypedefs as Microsoft does on that platform when buildingwith Visual Studio.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.