AST: re-order copy constructor, remove extra copy constructor #19301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @DougGregor |
jckarter
reviewed
Sep 13, 2018
compnerd
force-pushed
the
ast-special-copy
branch
2 times, most recently
from
d259d5d to
cbf974a
Compare
Visual Studio objects with the following: ``` AST/AnyRequest.h(243): error: C2580: 'swift::AnyRequest::AnyRequest(const swift::AnyRequest &)': multiple versions of a defaulted special member functions are not allowed AST/AnyRequest(243): warning C4521: 'swift::AnyRequest': multiple copy constructors specified ``` Remove the non-const implementation, the default'ed definition should be sufficient. Additionally, remove the nonsense const move constructor.
compnerd
force-pushed
the
ast-special-copy
branch
from
9e090d4 to
d9aaaed
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio objects with the following:
Remove the non-const implementation, the default'ed definition should be
sufficient. Additionally, re-order to keep the const and non-const r-value ref
versions next to each other.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.