[ABI] Add default associated type witnesses to resilient protocols. #19336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
force-pushed
the
associated-type-defaults
branch
from
3861687 to
204af17
Compare
|
@swift-ci please test |
|
Build failed |
Put a DenseMap onto the ASTContext’s implementation instead.
SILWitnessTable::Entry already contains a superset of what was supported by SILDefaultWitnessTable::Entry, the latter of which only had “no entry” and “method” states. Make SILDefaultWitnessTable::Entry an alias for SILWitnessTable::Entry, and unify all of the parsing/printing/ (de)serialization logic.
When an associated type witness has a default, record that as part of the protocol and emit a default associated type metadata accessor into the default witness table. This allows a defaulted associated type to be added to a protocol resiliently. This is another part of rdar://problem/44167982, but it’s still very limiting because the new associated type cannot have any conformances.
There is no good way to do this, so take a shortcut for now of pre-resolving ‘Self’.
DougGregor
force-pushed
the
associated-type-defaults
branch
from
204af17 to
ccb1c9a
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an associated type witness has a default, record that as part of
the protocol and emit a default associated type metadata accessor into the
default witness table. This allows a defaulted associated type to be
added to a protocol resiliently.
This is another part of rdar://problem/44167982, but it’s still very
limiting because the new associated type cannot have any conformances.