Skip to content

[Syntax] Update DeclNodes.py for designated protocols parsing support. #19337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2018
Merged

[Syntax] Update DeclNodes.py for designated protocols parsing support. #19337

merged 2 commits into from
Sep 18, 2018

Conversation

rudkx
Copy link
Contributor

@rudkx rudkx commented Sep 15, 2018

SwiftSyntax support for #19145.

@rudkx rudkx requested a review from rintaro September 15, 2018 07:26
@rudkx
Copy link
Contributor Author

rudkx commented Sep 15, 2018

@swift-ci Please smoke test

@rudkx rudkx requested a review from harlanhaskins September 18, 2018 05:11
@harlanhaskins
Copy link
Contributor

Looks correct. Can you update the grammar comment above that node to

# infix-operator-group -> ':' identifier ‘,’? identifier?

@rudkx
Copy link
Contributor Author

rudkx commented Sep 18, 2018

@swift-ci Please smoke test

harlanhaskins
harlanhaskins approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@harlanhaskins harlanhaskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rudkx rudkx merged commit d3fdfef into swiftlang:master Sep 18, 2018
@rudkx rudkx deleted the swift-syntax-for-operator-designated-protocols branch September 18, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlanhaskins harlanhaskins harlanhaskins approved these changes

@rintaro rintaro Awaiting requested review from rintaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudkx @harlanhaskins