Index: Don't crash if an optional requirement is missing its witness #19378
Conversation
|
@swift-ci Please smoke test |
test/Index/objc_conformances.swift
Outdated
| // RUN: %target-swift-ide-test -print-indexed-symbols -source-filename %s | ||
|
|
||
| // Let's just make sure this doesn't crash for now; there's nothing interesting | ||
| // to see in the output here. |
There was a problem hiding this comment.
Nitpick: validation-test, then?
There was a problem hiding this comment.
We might add more test cases later, with CHECK lines.
There was a problem hiding this comment.
If you add at least a single CHECK line it will be useful to serve as a sanity check that AST walking did take place.
There was a problem hiding this comment.
I’ll add a non-optional requirement and check that the witness got walked.
test/Index/objc_conformances.swift
Outdated
| @@ -0,0 +1,12 @@ | |||
| // RUN: %target-swift-ide-test -print-indexed-symbols -source-filename %s | |||
There was a problem hiding this comment.
I think this needs REQUIRES: objc_interop.
Also if import Foundation is required to be in the test case, I'd suggest to change to // RUN: %target-swift-ide-test(mock-sdk: %clang-importer-sdk)
There was a problem hiding this comment.
You’re right, thanks.
Possibly fixes <rdar://problem/44499860>.
slavapestov
force-pushed
the
index-while-building-crash
branch
from
22cf003 to
28c5ad3
Compare
|
@swift-ci Please smoke test |
Possibly fixes rdar://problem/44499860.