SILGen: Port reabstraction thunks to the new function type representation #19384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
remove-function-input-abstraction-pattern
branch
2 times, most recently
from
a8f8430 to
266e962
Compare
I'm going to need this when emitting reabstraction thunks using the new function pointer representation.
Treat the top level of the parameter list specially, instead of looking at FunctionType::getInput(). There are three cases where we don't translate parameters 1-1: - Imploding the parameter list into a single value when reabstracting a function with the opaque abstraction pattern. This will go away once Swift 3 compatibility is fully removed. - Exploding the parameter list from a single value. This is the dual of the above. - Exploding the parameter list for an SE-0110 "tuple splat" conversion. This is the one case that will need to be supported on an on-going basis, but it is not too bad to handle directly.
Now that we handle the top-level parameter list specially, we never end up with non-materializable tuples here, or other odd cases like one-element tuples, so a bunch of complexity can be eliminated.
slavapestov
force-pushed
the
remove-function-input-abstraction-pattern
branch
from
266e962 to
e7b911e
Compare
slavapestov
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
fluent failure is the same non-deterministic associated type thing (rdar://44777661). |
rjmccall
approved these changes
Sep 26, 2018
| @@ -892,11 +879,102 @@ namespace { | |||
| AnyFunctionType::CanParamArrayRef inputSubstTypes, | |||
| AbstractionPattern outputOrigFunctionType, | |||
| AnyFunctionType::CanParamArrayRef outputSubstTypes) { | |||
| // FIXME: Do we ever do opaque-to-opaque reabstractions? | |||
| assert(!inputOrigFunctionType.isTypeParameter() || | |||
| !outputOrigFunctionType.isTypeParameter()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the last place we used AbstractionPattern::getFunctionInputType(), so a lot of old code can be removed now.