[stdlib] Portable random function #1939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _swift_stdlib_cxx11_mt19937_uniform(__swift_uint32_t upper_bound) { | ||
| if (upper_bound > 0) | ||
| upper_bound--; | ||
| std::uniform_int_distribution<int> RandomUniform(0, upper_bound); |
There was a problem hiding this comment.
Why not std::uniform_int_distribution<__swift_uint32_t>?
|
@tinysun212 LGTM, only minor comments! Let's test this as well: @swift-ci Please test |
| @@ -105,7 +105,7 @@ func helperDeleteThree(k1: TestKeyTy, _ k2: TestKeyTy, _ k3: TestKeyTy) { | |||
| } | |||
|
|
|||
| func uniformRandom(max: Int) -> Int { | |||
| return Int(arc4random_uniform(UInt32(max))) | |||
| return Int(cxx11_mt19937_uniform(UInt32(max))) | |||
There was a problem hiding this comment.
Looks like this should be calling rand32() instead.
|
LGTM, let's merge. @swift-ci Please test and merge |
|
@tinysun212 Sorry! CI hit an error: |
Changed rand32() implementation using a random engine in C++11 <random>.
tinysun212
force-pushed
the
pr-portable-random
branch
from
b6c4e2f to
5c1854b
Compare
|
Fixed and squashed. |
|
@swift-ci Please test and merge |
gribozavr
added a commit
that referenced
this pull request
Mar 30, 2016
We were only using arc4random, and now we use C++ <random> instead. See also PR #1939.
benrimmington
added a commit
to benrimmington/swift
that referenced
this pull request
Aug 1, 2018
SwiftPrivate/PRNG.swift: - currently uses `theGlobalMT19937`; - previously used `arc4random` (see swiftlang#1939); - is obsoleted by SE-0202: Random Unification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: N/A
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.
Changed rand32() implementation using a random engine in C++11
<random>.