Skip to content

Make runtime warnings about missing metadata more descriptive. #19415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2018
Merged

Make runtime warnings about missing metadata more descriptive. #19415

merged 1 commit into from
Sep 20, 2018

Conversation

jckarter
Copy link
Contributor

Describe the consequences of missing metadata instead of just posting a scary
message about a bug. Furthermore, since these warnings tend to show up in
playgrounds, and probably aren't relevant to the user of a playground, suppress
them when running in a playground. rdar://problem/44642942

@jckarter jckarter requested review from cwakamo and mikeash September 20, 2018 15:57
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter jckarter force-pushed the better-missing-metadata-warnings branch from a6e14e7 to 7757b8f Compare September 20, 2018 16:19
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a6e14e76ea78b528a4e2764a252ca4e772819398

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a6e14e76ea78b528a4e2764a252ca4e772819398

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a6e14e76ea78b528a4e2764a252ca4e772819398

@jckarter jckarter force-pushed the better-missing-metadata-warnings branch from 7757b8f to 6582140 Compare September 20, 2018 18:30
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7757b8f6a5d7671dca1f33045a630f03c43406ce

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a6e14e76ea78b528a4e2764a252ca4e772819398

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7757b8f6a5d7671dca1f33045a630f03c43406ce

@jckarter
Make runtime warnings about missing metadata more descriptive.
e9b4517 
Describe the consequences of missing metadata instead of just posting a scary
message about a bug.  Furthermore, since these warnings tend to show up in
playgrounds, and probably aren't relevant to the user of a playground, suppress
them when running in a playground. rdar://problem/44642942
@jckarter jckarter force-pushed the better-missing-metadata-warnings branch from 6582140 to e9b4517 Compare September 20, 2018 20:04
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 65821404dac69afad556fe5381e8895ee3f279e7

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 65821404dac69afad556fe5381e8895ee3f279e7

@jckarter jckarter merged commit bbbf02e into swiftlang:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash mikeash approved these changes

@cwakamo cwakamo Awaiting requested review from cwakamo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jckarter @swift-ci @mikeash