build: use the target variables for the ICU check #19418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
jrose-apple
reviewed
Sep 20, 2018
The ICU library is used for the target library, not the host tools. Use the appropriate variable `SWIFT_PRIMARY_VARIANT_SDK` and `SWIFT_PRIMARY_VARIANT_ARCH` to select the right CMake variables for the ICU definitions. There is no need to use the `_default` suffixed versions as the defaults have already been used to set the value above.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ICU library is used for the target library, not the host tools. Use the
appropriate variable
SWIFT_PRIMARY_VARIANT_SDKandSWIFT_PRIMARY_VARIANT_ARCHto select the right CMake variables for the ICUdefinitions. There is no need to use the
_defaultsuffixed versions as thedefaults have already been used to set the value above.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.