[CSStep] Allocate component scopes only if siblings didn't fail

[xedin]

If sibling components failed, there is no reason to establish new
scope since remaining containers are not really going to be taken
but fail fast instead.

[xedin]

@swift-ci please smoke test

[xedin]

@swift-ci please smoke test compiler performance

[swift-ci]

Build comment file:

Summary for master smoketest

Unexpected test results, excluded stats for Kingfisher, ReactiveCocoa

No regressions above thresholds

• Debug
  • debug brief
  • debug detailed
• Release
  • release brief
  • release detailed

Debug

debug brief

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (3)

name	old	new	delta	delta_pct
Frontend.NumInstructionsExecuted	238,916,979,952	238,825,086,115	-91,893,837	-0.04%
LLVM.NumLLVMBytesOutput	9,529,272	9,529,272	0	0.0%
time.swift-driver.wall	26.1s	26.1s	8.9ms	0.03%

debug detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (23)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	5,966	5,966	0	0.0%
AST.NumLoadedModules	1,510	1,510	0	0.0%
AST.NumTotalClangImportedEntities	18,342	18,342	0	0.0%
AST.NumUsedConformances	1,344	1,344	0	0.0%
IRModule.NumIRBasicBlocks	32,501	32,501	0	0.0%
IRModule.NumIRFunctions	16,736	16,736	0	0.0%
IRModule.NumIRGlobals	14,485	14,485	0	0.0%
IRModule.NumIRInsts	445,426	445,426	0	0.0%
IRModule.NumIRValueSymbols	29,941	29,941	0	0.0%
LLVM.NumLLVMBytesOutput	9,529,272	9,529,272	0	0.0%
SILModule.NumSILGenFunctions	7,845	7,845	0	0.0%
SILModule.NumSILOptFunctions	10,595	10,595	0	0.0%
Sema.NumConformancesDeserialized	33,921	33,921	0	0.0%
Sema.NumConstraintScopes	72,576	72,225	-351	-0.48%
Sema.NumDeclsDeserialized	273,449	273,449	0	0.0%
Sema.NumDeclsValidated	16,641	16,641	0	0.0%
Sema.NumFunctionsTypechecked	7,085	7,085	0	0.0%
Sema.NumGenericSignatureBuilders	11,506	11,506	0	0.0%
Sema.NumLazyGenericEnvironments	54,591	54,591	0	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	6,243	6,243	0	0.0%
Sema.NumLazyIterableDeclContexts	45,799	45,799	0	0.0%
Sema.NumTypesDeserialized	126,280	126,280	0	0.0%
Sema.NumTypesValidated	14,185	14,185	0	0.0%

Release

release brief

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (3)

name	old	new	delta	delta_pct
Frontend.NumInstructionsExecuted	233,159,182,614	233,130,359,964	-28,822,650	-0.01%
LLVM.NumLLVMBytesOutput	10,607,604	10,607,604	0	0.0%
time.swift-driver.wall	43.5s	43.4s	-135.3ms	-0.31%

release detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (23)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	1,385	1,385	0	0.0%
AST.NumLoadedModules	100	100	0	0.0%
AST.NumTotalClangImportedEntities	4,901	4,901	0	0.0%
AST.NumUsedConformances	1,346	1,346	0	0.0%
IRModule.NumIRBasicBlocks	34,343	34,343	0	0.0%
IRModule.NumIRFunctions	15,067	15,067	0	0.0%
IRModule.NumIRGlobals	13,931	13,931	0	0.0%
IRModule.NumIRInsts	335,420	335,420	0	0.0%
IRModule.NumIRValueSymbols	27,934	27,934	0	0.0%
LLVM.NumLLVMBytesOutput	10,607,604	10,607,604	0	0.0%
SILModule.NumSILGenFunctions	6,074	6,074	0	0.0%
SILModule.NumSILOptFunctions	9,017	9,017	0	0.0%
Sema.NumConformancesDeserialized	16,740	16,740	0	0.0%
Sema.NumConstraintScopes	71,136	70,785	-351	-0.49%
Sema.NumDeclsDeserialized	52,249	52,249	0	0.0%
Sema.NumDeclsValidated	10,362	10,362	0	0.0%
Sema.NumFunctionsTypechecked	4,362	4,362	0	0.0%
Sema.NumGenericSignatureBuilders	2,592	2,592	0	0.0%
Sema.NumLazyGenericEnvironments	9,469	9,469	0	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	1,346	1,346	0	0.0%
Sema.NumLazyIterableDeclContexts	5,990	5,990	0	0.0%
Sema.NumTypesDeserialized	30,887	30,887	0	0.0%
Sema.NumTypesValidated	7,103	7,103	0	0.0%

---