[4.2] Obsolete unsafeArithmetic operations on Integers. #19425
Conversation
stephentyrone
changed the title
|
@swift-ci please smoke test. |
|
Should we move them to the |
|
4.2 doesn’t have MigrationSupport.swift? |
|
Nope. Did that after. |
|
Do we want a comment too? Not sure if why they're going away can be pithily expressed in a sentence (maybe using emoji) |
|
@swift-ci please test. |
|
@airspeedswift I wanted to write a comment, but really couldn't come up with one that wasn't a short essay, and also I remembered that no one actually uses these, so it would be write-once read-never. |
|
@swift-ci nominate |
| @@ -2938,6 +2938,7 @@ ${assignmentOperatorComment(x.operator, True)} | |||
| #endif | |||
| // end of FIXME(integers) | |||
|
|
|||
| @available(swift, deprecated: 4.2, obsoleted: 5) | |||
There was a problem hiding this comment.
Nit: It works up here, but this should be below the documentation comment and indented to match @inlinable.
|
No need to update the comment — the tools show the necessary deprecation notices, so the docs can remain focused on the behavior. |
Mark these deprecated as of 4.2, per discussion with core team and https://forums.swift.org/t/removing-unsafe-arithmetic-methods/16169
They will be removed in 5.0 via a second PR.
Scope: Deprecate some operations that are unused and an attractive nuisance.
Radar: rdar://problem/43688685
Risk: Low – as far as we know, no one uses these.
Testing: Normal test suite.
Reviewers: @airspeedswift