[sil] Introduce FullApplySiteKind and ApplySiteKind to allow for exha… #19436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
Was just thinking... It may make sense for FullApplySiteKind to be a range instead of a unique type. |
|
No. I am wrong. Sorry, I confused myself. |
|
@swift-ci smoke test macOS platform |
atrick
approved these changes
Sep 21, 2018
include/swift/SIL/SILInstruction.h
Outdated
| operator innerty() const { return value; } | ||
|
|
||
| static Optional<ApplySiteKind> | ||
| mapNodeKindToApplySiteKind(SILInstructionKind kind) { |
gottesmm
force-pushed
the
pr-e2ea20678fd79a26d047317cef26331dddb0298e
branch
from
8d8facf to
d783db4
Compare
|
Fixed and merging! |
|
@swift-ci smoke test and merge |
…ustive switching over FullApplySites and ApplySiteKind. Currently there is a bug in the closure specializer that was caused by BeginApply not being handled correctly. Rather than just fixing that and leaving the badness, I am instead in this commit introducing enums for apply sites so we can avoid this problem in the future by using exhaustive switches to guide developers adding new types of apply sites in the future. rdar://44612356
gottesmm
force-pushed
the
pr-e2ea20678fd79a26d047317cef26331dddb0298e
branch
from
d783db4 to
e3eb9ae
Compare
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ustive switching over FullApplySites and ApplySiteKind.
Currently there is a bug in the closure specializer that was caused by
BeginApply not being handled correctly. Rather than just fixing that and leaving
the badness, I am instead in this commit introducing enums for apply sites so we
can avoid this problem in the future by using exhaustive switches to guide
developers adding new types of apply sites in the future.
rdar://44612356
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.