[CSDiagnostics] Don't mention special names in requirement diagnostics #19447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of `initializer 'init' of ...` diagnostic should only mention kind e.g. `initializer of ...` of the declaration with a special name.
|
@swift-ci please test |
|
I think it doesn't really make sense to mention special names because note is going to point to the right place anyway... |
|
No, the names are there so that you can see the parameter names. Please revert. |
|
Alright, fair enough |
|
As mentioned in the linked PR, I'd change the condition to skip names only if they are special and there are no labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
initializer 'init' of ...diagnostic should onlymention kind e.g.
initializer of ...of the declarationwith a special name.