[ModuleInterface] Print names for @usableFromInline struct properties #19465
Conversation
Because they weren't 'public' we were treating them as layout-only properties and printing `var _`, but they get referenced in inlinable functions. We need the actual name!
|
@slavapestov This check comes up a lot. I wonder if it's worth making an accessor for, or if that's going to be a pitfall. @swift-ci Please smoke test |
|
@jrose-apple Is it not the same as |
|
No, that would include testable things too. This is still a Swift-level query, not a SIL-level query. |
|
@jrose-apple Do generated interfaces need to include effectively-public-because-of-enable-testable things? Because then anything that's @usableFromInline becomes effectively public by virtue of being internal. |
|
Generated interfaces are currently not scoped for use for testable things, and testable things aren't checked for all the additional Sema rules today. But no one's been testing -enable-testing with -enable-resilience, so it wouldn't surprise me if there are holes because of that. |
|
@slavapestov Any further comments for now? |
Because they weren't 'public' we were treating them as layout-only properties and printing
var _, but they get referenced in inlinable functions. We need the actual name!