[android] Duplicate some arm64 checks for aarch64. #19478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested changes
Oct 4, 2018
drodriguez
force-pushed
the
android-aarch64-test-fix-1
branch
from
b753bf8 to
ee9e4c2
Compare
drodriguez
force-pushed
the
android-aarch64-test-fix-1
branch
from
ee9e4c2 to
eade0e4
Compare
|
@drodriguez Do we still need these changes? |
|
I think it might be. In the case of AArch64 architectures (Linux, Android, Windows (?)), the CPU is called Is there interest in merging? I can try to rebase and check that it still works, if there's interest. |
|
Seems like we can take this as-is @swift-ci please smoke test |
|
⛵️ |
drodriguez
added a commit
to drodriguez/swift
that referenced
this pull request
Dec 2, 2019
In between swiftlang#19478 was written and merged, b45ca04 changed the spelling of the intrinsics, so the old code wasn't working. This fixes the spelling. Broken in https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/2875/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.