Skip to content

[CSBindings] Don't consider dependent member types even if they are w… #19554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Sep 26, 2018

…rapped in optionals

Because binding producer is going to attempt to unwrap optionals
and try the type, which would lead to infinite recursion because
dependent member types aren't bindable.

Resolves: rdar://problem/44770297

…rapped in optionals

Because binding producer is going to attempt to unwrap optionals
and try the type, which would lead to infinite recursion because
dependent member types aren't bindable.

Resolves: rdar://problem/44770297
@xedin
Copy link
Contributor Author

xedin commented Sep 26, 2018

@swift-ci please smoke test

@xedin xedin requested a review from nathawes September 26, 2018 04:01
@xedin
Copy link
Contributor Author

xedin commented Sep 26, 2018

@swift-ci please test source compatibility

@xedin xedin merged commit 698dd39 into swiftlang:master Sep 26, 2018
Copy link
Contributor

@nathawes nathawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants