Skip to content

[gardening] Rename references to SILPHIArgument => SILPhiArgument. #19557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

At Andy's request.

@gottesmm gottesmm requested a review from atrick September 26, 2018 05:25
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@atrick
Copy link
Contributor

atrick commented Sep 26, 2018

😃 😃 😃

Background: LLVM contained this problem to the original "PHINode" (probably circa 2004), and LLVM developers have been good about not letting the problem spread beyond that to other Phi-names. We definitely don't want bring that horror back to life.

@gottesmm gottesmm merged commit 8ab8e75 into swiftlang:master Sep 26, 2018
@gottesmm gottesmm deleted the pr-39539664cf3e8eeadf30363e1f27d58cca0974fb branch September 26, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants