try! error message should report the right location #19565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the location being reported is inside the standard library, which is not very helpful. Instead, the location should point at the `try!` expression in the application code. Fixes: rdar://problem/21407683
moiseev
force-pushed
the
try-bang-location-info
branch
from
75b6d91 to
7c7a976
Compare
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test macOS platform |
|
Build failed |
|
@swift-ci Please clean smoke test macOS platform |
|
@swift-ci Please clean test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the location being reported is inside the standard
library, which is not very helpful. Instead, the location should point
at the
try!expression in the application code.Fixes: rdar://problem/21407683