remove some tf-specific stuff from constexpr code #19577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
mhong
approved these changes
Sep 27, 2018
| @@ -38,8 +38,6 @@ class SILValue; | |||
| class SymbolicValue; | |||
| enum class UnknownReason; | |||
|
|
|||
| namespace tf { | |||
There was a problem hiding this comment.
do you also want to rename TFConstExpr.h to sth like ConstExpr.h?
There was a problem hiding this comment.
I am unsure about what the final location and name of these files will be, so I will defer all moving/renaming until the patch review gives me a good idea of what they will be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make for slightly fewer conflicts when we send the constexpr patch upstream.