[CodeCompletion] Improve accuracy of unresolved member completion #19584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
I'm not sure these are officially supported: // Implicit member expression via member type construction.
class Base {
class Derived : Base {}
}
let _: Base = .Derived()
// Implicit member expression via calling closure type static property.
struct Foo {
static var factory: () -> Foo = { fatalError() }
}
let _: Foo = .factory()I included them because the current compiler allows them. |
rintaro
force-pushed
the
ide-completion-unresolvedmember-accurate
branch
from
2e05863 to
028fd6c
Compare
|
@swift-ci Please smoke test |
|
@rintaro If they're allowed they're "supported". We don't have a formal spec :) At least the nested type case is something I've seen in real code before. Can you make sure they're tested somewhere in |
* Handle generic base types * Suggest '.some' and '.none' for optional types * Don't look through too many parameter lists for function types * Include members with convertible type result rdar://problem/44803439
benlangmuir
approved these changes
Sep 28, 2018
| // UNRESOLVED_3_OPTOPTOPT-DAG: Decl[EnumElement]/ExprSpecific: North[#SomeEnum1#]; | ||
| // UNRESOLVED_3_OPTOPTOPT-DAG: Decl[EnumElement]/ExprSpecific: South[#SomeEnum1#]; | ||
| // UNRESOLVED_3_OPTOPTOPT-DAG: Decl[EnumElement]/ExprSpecific: none[#Optional<Wrapped>#]; name=none | ||
| // UNRESOLVED_3_OPTOPTOPT-DAG: Decl[EnumElement]/ExprSpecific: some({#Wrapped#})[#(Wrapped) -> Optional<Wrapped>#]; |
There was a problem hiding this comment.
Do we know why the generic Wrapped isn't resolved here?
There was a problem hiding this comment.
Yeah, that is what I'm wondering too. I'll look into it in followups.
Some uncommon cases including: * Closure static properties * Nested types
rintaro
force-pushed
the
ide-completion-unresolvedmember-accurate
branch
from
028fd6c to
07545b9
Compare
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #19567 (comment)
.someand.nonefor optional typesrdar://problem/44803439