Skip to content

[stdlib] Set, Dictionary: Prepare for per-instance hash seeds #19589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2018

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Sep 27, 2018

Implement the per-instance seeding infrastructure without actually enabling per-instance seeding.

This is #19533 except for the crucial step of actually generating a new seed.

rdar://problem/44760778

@lorentey
Copy link
Member Author

@swift-ci please test source compatibility

@lorentey
Copy link
Member Author

@swift-ci please test

@lorentey
Copy link
Member Author

Ah, facepalm. Swiftpm is failing because I forgot updating mapValues to copy the seed over.

Clearly we don't have enough test coverage for mapValues.

@lorentey
Copy link
Member Author

@swift-ci please test source compatibility

@lorentey
Copy link
Member Author

FAIL: fluent, 4.2, 270b6f, Swift Package

But how

@lorentey lorentey force-pushed the prepare-for-per-instance-seeds branch from 08b8f3f to b92c301 Compare September 28, 2018 03:05
@lorentey
Copy link
Member Author

@swift-ci please smoke test

@lorentey lorentey merged commit ee4ad7a into swiftlang:master Sep 28, 2018
@lorentey lorentey deleted the prepare-for-per-instance-seeds branch October 9, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant