swift-module-digester: always canonicalize super class types.

[nkcsgexi]

No description provided.

[nkcsgexi]

@swift-ci please smoke test

[slavapestov]

Do you canonicalize all types, or just superclasses?

[nkcsgexi]

We canonicalize all types when checking ABI stability. This patch is to canonicalize super class type names disregarding of checking ABI or source compatibility.

[nkcsgexi]

@swift-ci please smoke test

[slavapestov]

@nkcsgexi Why do you need to canonicalize superclass types but not other types when checking API stability?

[nkcsgexi]

Because synthesizing type alias of the same name with an old type is an api-notes' way to maintain source-compatibility for many frameworks.

[slavapestov]

@nkcsgexi I see, so its specific to imported modules? Maybe you should conditionalize the check on that hten.

[nkcsgexi]

yeah, i think it's specific to imported module. Since we'll deploy ABI checker for Swift modules with all types canonicalized, i'm not sure it's useful to introduce another flag.

[nkcsgexi]

@swift-ci please smoke test