Skip to content

[stdlib] Set, Dictionary: Make reserveCapacity non-inlinable #19604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

lorentey
Copy link
Member

This allows us to record the reserved capacity in storage later, which will enable removals to resize the hash table.

This allows us to record the reserved capacity in storage later, which will enable removals to resize the hash table.
@lorentey
Copy link
Member Author

@swift-ci please smoke test

@lorentey
Copy link
Member Author

@swift-ci please smoke benchmark

@swift-ci
Copy link
Contributor

Build comment file:

Performance: -O

TEST OLD NEW DELTA RATIO
Regression
IterateData 1565 1742 +11.3% 0.90x

Performance: -Osize

TEST OLD NEW DELTA RATIO
Regression
DictionaryCompactMapValuesOfNilValue 8078 8985 +11.2% 0.90x
IterateData 1630 1796 +10.2% 0.91x (?)

Performance: -Onone

TEST OLD NEW DELTA RATIO
Improvement
CharIndexing_japanese_unicodeScalars_Backwards 493051 415015 -15.8% 1.19x
CharIndexing_punctuatedJapanese_unicodeScalars_Backwards 70686 59915 -15.2% 1.18x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@lorentey lorentey merged commit 6f51edc into swiftlang:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants