You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should no longer need these with the protocol-based integer support we now have. Some small work may be needed to fix performance regressions, but that will come in a follow-on update.
I did have to keep the concrete init from Int around to keep the type checker from failing in some new cases; I hope we can remove that too in the future.
Rework Self._convert from integer, by making it require RawSignificand: FixedWidthInteger
This requirement should have always been there, and the existing implementaiton wouldn't
have actually worked correctly without it. Making it explcit makes the implementation quite
a bit simpler, which is nice.
Add fast-path conversion that will catch all concrete integer types without needing to be
a concrete implementation itself. Room for further improvement, but good start.
How to read the data
The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).
Hardware Overview
Model Name: Mac Pro
Model Identifier: MacPro6,1
Processor Name: 12-Core Intel Xeon E5
Processor Speed: 2.7 GHz
Number of Processors: 1
Total Number of Cores: 12
L2 Cache (per Core): 256 KB
L3 Cache: 30 MB
Memory: 64 GB
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should no longer need these with the protocol-based integer support we now have. Some small work may be needed to fix performance regressions, but that will come in a follow-on update.
I did have to keep the concrete init from Int around to keep the type checker from failing in some new cases; I hope we can remove that too in the future.
Fixes rdar://problem/33199966