[CodeCompletion] Pre-remove argument labels from function types #19635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before checking type relation between candidate types and expected types. In normal compilation, this removal is done in CSGen. However, since code-completion directly uses Constraint System, we have to manually remove argument labels before checking convertibility. We can remove argument labels unconditionally because function types as as value cannot have argument labels. (i.e. `let f: (a: Int) -> Int` is illegal). That means, expected types shouldn't have any argument labels. This fixes regression revealed in 5e75b1a rdar://problem/41496748
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before checking type relation between candidate types and expected types. In normal compilation, this removal is done in
CSGen. However, since code-completion directly uses Constraint System, we have to manually remove argument labels before checking convertibility.We can remove argument labels unconditionally because function types as value cannot have argument labels. (i.e.
var fn: (a: Int) -> Intis illegal). That means, expected types shouldn't have any argument labels.This fixes regression revealed in 5e75b1a
rdar://problem/41496748