SILOptimizer: fix non-deterministic behavior in RedundantLoadElimination and DeadStoreElimination. #19648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci benchmark |
Build comment file:No performance and code size changesHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR. Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein). Hardware Overview |
jrose-apple
reviewed
Oct 1, 2018
| bool | ||
| LSLocation::reduce(LSLocation Base, SILModule *M, LSLocationSet &Locs) { | ||
| /// Does a location list contain a specific location? | ||
| static bool contains(const LSLocationList &Locs, const LSLocation &L) { |
There was a problem hiding this comment.
llvm::is_contained already does this.
There was a problem hiding this comment.
Ah, thanks. I'll change it
…ion and DeadStoreElimination. Replace some DenseSets, which are used for iteration, with vectors. SR-8844 rdar://problem/44762620
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some DenseSets, which are used for iteration, with vectors.
This also needed some rewrite in LSLocation::reduce() to rule out quadratic complexity.
SR-8844
rdar://problem/44762620