Skip to content

SourceKit: repair the build when cross-compiling #19650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Oct 1, 2018

Not all targets (CMAKE_SYSTEM_NAME) use lib and .a for the static library
name. Adjust the name properly for the host that we are building for. This
repairs the build when performing a cross-compile from Linux to Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Not all targets (CMAKE_SYSTEM_NAME) use `lib` and `.a` for the static library
name.  Adjust the name properly for the host that we are building for.  This
repairs the build when performing a cross-compile from Linux to Windows.
@compnerd
Copy link
Member Author

compnerd commented Oct 1, 2018

@swift-ci please test and merge

@compnerd
Copy link
Member Author

compnerd commented Oct 1, 2018

CC: @gottesmm @Rostepher

@swift-ci swift-ci merged commit d401f96 into swiftlang:master Oct 2, 2018
@compnerd compnerd deleted the prefix-suffix branch April 24, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants