[AST] static_assert that Decls, Stmts, and Exprs don't need cleanup #19667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These types are all allocated on the ASTContext's BumpPtrAllocator, and by default their destructors are never called. (ModuleDecl is the exception; it registers its destructor with the ASTContext on construction.) No functionality change.
|
@swift-ci Please smoke test |
xedin
approved these changes
Oct 2, 2018
harlanhaskins
approved these changes
Oct 2, 2018
rintaro
approved these changes
Oct 2, 2018
|
Good point, those all follow these rules too. I should probably just look at everything ASTWalker can visit. |
rudkx
approved these changes
Oct 2, 2018
modelorganism
pushed a commit
to modelorganism/swift
that referenced
this pull request
Oct 11, 2018
…wiftlang#19667) These types are all allocated on the ASTContext's BumpPtrAllocator, and by default their destructors are never called. (ModuleDecl is the exception; it registers its destructor with the ASTContext on construction.) No functionality change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types are all allocated on the ASTContext's BumpPtrAllocator, and by default their destructors are never called. (ModuleDecl is the exception; it registers its destructor with the ASTContext on construction.)
No functionality change.