[Frontend] Allow -emit-interface with -typecheck #19676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
| /// These are extracted out so that they can be invoked early when using | ||
| /// `-typecheck`, but skipped for any mode that runs SIL diagnostics if there's | ||
| /// an error found there (to get those diagnostics back to the user faster). | ||
| static bool emitAnyWholeModulePostTypeCheckSupplementaryOutputs( |
There was a problem hiding this comment.
This is much nicer, thank you!
| @@ -1,3 +1,4 @@ | |||
| // RUN: %target-swift-frontend -typecheck -emit-interface-path - -parse-stdlib %s | %FileCheck %s | |||
| // RUN: %target-swift-frontend -emit-interface-path - -emit-module -o /dev/null -parse-stdlib %s | %FileCheck %s | |||
There was a problem hiding this comment.
I think this line can be removed
There was a problem hiding this comment.
Ah, I wanted to have at least one test that did things both ways; a -parse-stdlib test seemed like a good example.
|
Aha, yes, the very thing I changed was, in fact, being tested. |
Textual module interfaces don't actually depend on SILGen, so we shouldn't need to run SILGen (or serialize an entire binary module) if we're just trying to emit a textual interface. On the other hand, if we /are/ going to run SILGen and then SIL diagnostics, we shouldn't delay those diagnostics by spending time emitting a textual interface, or for that matter a TBD file. Using this, update all the ModuleInterface tests that use `-emit-module -o /dev/null` to use `-typecheck` instead, except for those using `-merge-modules`.
|
Debug source compat, Release source compat. @swift-ci Please smoke test |
harlanhaskins
approved these changes
Oct 3, 2018
modelorganism
pushed a commit
to modelorganism/swift
that referenced
this pull request
Oct 11, 2018
Textual module interfaces don't actually depend on SILGen, so we shouldn't need to run SILGen (or serialize an entire binary module) if we're just trying to emit a textual interface. On the other hand, if we /are/ going to run SILGen and then SIL diagnostics, we shouldn't delay those diagnostics by spending time emitting a textual interface, or for that matter a TBD file. Using this, update all the ModuleInterface tests that use `-emit-module -o /dev/null` to use `-typecheck` instead, except for those using `-merge-modules`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textual module interfaces don't actually depend on SILGen, so we shouldn't need to run SILGen (or serialize an entire binary module) if we're just trying to emit a textual interface. On the other hand, if we are going to run SILGen and then SIL diagnostics, we shouldn't delay those diagnostics by spending time emitting a textual interface, or for that matter a TBD file.
Using this, update all the ModuleInterface tests that use
-emit-module -o /dev/nullto use-typecheckinstead, except for those using-merge-modules.