[stdlib] Underscore usable-from-inline types

[airspeedswift]

Makes sure all internal methods that are @usableFromInline have an underscore, in case some day we want to create a public version with the same name.

Also adds some constraints that appeared to be missing from _ArrayProtocol, and separates out the conformances to it to match std lib style.

[airspeedswift]

@swift-ci please test

[airspeedswift]

@swift-ci please smoke benchmark

[airspeedswift]

@swift-ci please smoke test compiler performance

[swift-ci]

Build comment file:

Performance: -Osize

TEST	OLD	NEW	DELTA	RATIO
Improvement
DictionaryKeysContainsNative	43	29	-32.6%	1.48x
AnyHashableWithAClass	135429	109504	-19.1%	1.24x
FloatingPointPrinting_Float_description_uniform	5806	5175	-10.9%	1.12x

Performance: -Onone

TEST	OLD	NEW	DELTA	RATIO
Regression
ArrayOfGenericPOD2	1067	1181	+10.7%	0.90x (?)
ArrayOfPOD	781	859	+10.0%	0.91x (?)

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview

  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

---

[swift-ci]

Build comment file:

Summary for master smoketest

Unexpected test results, excluded stats for Kingfisher, ReactiveCocoa

Regressions found (see below)

• Debug
  • debug brief
  • debug detailed
• Release
  • release brief
  • release detailed

Debug

debug brief

Regressed (1)

name	old	new	delta	delta_pct
time.swift-driver.wall	23.0s	23.4s	483.3ms	2.1% ⛔

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (2)

name	old	new	delta	delta_pct
Frontend.NumInstructionsExecuted	182,345,678,080	182,477,955,423	132,277,343	0.07%
LLVM.NumLLVMBytesOutput	9,605,544	9,605,552	8	0.0%

debug detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (23)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	4,559	4,559	0	0.0%
AST.NumLoadedModules	1,510	1,510	0	0.0%
AST.NumTotalClangImportedEntities	17,921	17,921	0	0.0%
AST.NumUsedConformances	1,352	1,352	0	0.0%
IRModule.NumIRBasicBlocks	32,920	32,920	0	0.0%
IRModule.NumIRFunctions	16,717	16,717	0	0.0%
IRModule.NumIRGlobals	14,612	14,612	0	0.0%
IRModule.NumIRInsts	445,665	445,665	0	0.0%
IRModule.NumIRValueSymbols	30,012	30,012	0	0.0%
LLVM.NumLLVMBytesOutput	9,605,544	9,605,552	8	0.0%
SILModule.NumSILGenFunctions	7,843	7,843	0	0.0%
SILModule.NumSILOptFunctions	10,695	10,695	0	0.0%
Sema.NumConformancesDeserialized	23,162	23,230	68	0.29%
Sema.NumConstraintScopes	70,308	70,308	0	0.0%
Sema.NumDeclsDeserialized	229,539	229,659	120	0.05%
Sema.NumDeclsValidated	16,641	16,641	0	0.0%
Sema.NumFunctionsTypechecked	6,090	6,090	0	0.0%
Sema.NumGenericSignatureBuilders	7,340	7,340	0	0.0%
Sema.NumLazyGenericEnvironments	52,236	52,302	66	0.13%
Sema.NumLazyGenericEnvironmentsLoaded	2,376	2,376	0	0.0%
Sema.NumLazyIterableDeclContexts	43,929	44,009	80	0.18%
Sema.NumTypesDeserialized	100,130	100,346	216	0.22%
Sema.NumTypesValidated	14,185	14,185	0	0.0%

Release

release brief

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (3)

name	old	new	delta	delta_pct
Frontend.NumInstructionsExecuted	221,266,764,454	221,362,915,460	96,151,006	0.04%
LLVM.NumLLVMBytesOutput	10,606,140	10,605,736	-404	-0.0%
time.swift-driver.wall	41.0s	41.0s	9.4ms	0.02%

release detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (23)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	1,111	1,111	0	0.0%
AST.NumLoadedModules	100	100	0	0.0%
AST.NumTotalClangImportedEntities	4,731	4,731	0	0.0%
AST.NumUsedConformances	1,354	1,354	0	0.0%
IRModule.NumIRBasicBlocks	34,999	34,999	0	0.0%
IRModule.NumIRFunctions	15,135	15,135	0	0.0%
IRModule.NumIRGlobals	13,939	13,939	0	0.0%
IRModule.NumIRInsts	334,304	334,304	0	0.0%
IRModule.NumIRValueSymbols	27,980	27,980	0	0.0%
LLVM.NumLLVMBytesOutput	10,606,140	10,605,736	-404	-0.0%
SILModule.NumSILGenFunctions	6,076	6,076	0	0.0%
SILModule.NumSILOptFunctions	9,077	9,032	-45	-0.5%
Sema.NumConformancesDeserialized	15,030	15,000	-30	-0.2%
Sema.NumConstraintScopes	69,604	69,604	0	0.0%
Sema.NumDeclsDeserialized	45,650	45,579	-71	-0.16%
Sema.NumDeclsValidated	10,362	10,362	0	0.0%
Sema.NumFunctionsTypechecked	4,162	4,162	0	0.0%
Sema.NumGenericSignatureBuilders	2,043	2,037	-6	-0.29%
Sema.NumLazyGenericEnvironments	10,022	10,007	-15	-0.15%
Sema.NumLazyGenericEnvironmentsLoaded	201	201	0	0.0%
Sema.NumLazyIterableDeclContexts	5,860	5,871	11	0.19%
Sema.NumTypesDeserialized	26,806	26,734	-72	-0.27%
Sema.NumTypesValidated	7,103	7,103	0	0.0%

---