[SourceKit] Make each Variant keep a strong reference to its SourceKitdResponse context #19689
+54
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nkcsgexi
approved these changes
Oct 3, 2018
| @@ -17,12 +17,14 @@ import sourcekitd | |||
| public class SourceKitdResponse: CustomStringConvertible { | |||
|
|
|||
| public struct Dictionary: CustomStringConvertible, CustomReflectable { | |||
| private let context: SourceKitdResponse | |||
There was a problem hiding this comment.
Good catch! Could you add some comments why we need a strong reference to the response object?
…tdResponse context sourcekitd_variant_t is only safe to use while the sourcekitd_response_t it was retrieved from is still alive, so keep a strong reference to SourceKitdResponse (the Swift wrapper of sourcekitd_response_t) in each Variant (the Swift wrapper of sourcekitd_variant_t).
nathawes
force-pushed
the
keep-sourcekitd-response-alive-while-variant-lives
branch
from
3dcff94 to
88b1ae9
Compare
|
@swift-ci please test |
|
Build failed |
|
Thanks for reviewing @nkcsgexi! Added the comments. |
|
Build failed |
nathawes
deleted the
keep-sourcekitd-response-alive-while-variant-lives
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourcekitd_variant_tis only safe to use while thesourcekitd_response_tit was retrieved from is still alive, so keep a strong reference toSourceKitdResponse(the Swift wrapper ofsourcekitd_response_t) in eachArray,DictionaryandVariant(Swift wrappers ofsourcekitd_variant_t).