swift-module-digester: use getEffectiveAccess() to get accessibility when checking ABI stability. #19697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when checking ABI stability. This allows us to include internal decls with @usableFromInline attribute, whose stored property changes can effect ABI.
|
@swift-ci please smoke test |
… checking stdlib abi stability.
nkcsgexi
force-pushed
the
effective-access
branch
from
f3ab621 to
b7c9e57
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to include internal decls with @usableFromInline attribute, whose stored property changes can affect ABI.
This PR also re-generates ABI baseline after incorporating this enhancement.