[silgen] Change silgen pattern to use destructure_tuple instead of bo… #19700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
…rrow + tuple_extract + copy. rdar://29791263
gottesmm
force-pushed
the
pr-ef927a3d187515aa9a630c73d9aeff2bbde00aa5
branch
from
66a6657 to
dbb3ba7
Compare
|
@swift-ci smoke test |
5 similar comments
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
slavapestov
approved these changes
Oct 4, 2018
|
@slavapestov this code is only conditionally enabled on sil ownership being enabled. Since SILGenPattern is not completely able to work with ownership yet the current switch tests do not run with ownership enabled... so yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rrow + tuple_extract + copy.
rdar://29791263