[test] Tweak some tests so that they run consistently on OS X 10.9 #19702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
jrose-apple
commented
Oct 3, 2018
| @@ -29,7 +29,6 @@ SubstringTests.test("Equality") { | |||
| expectEqual("fg" as String, s.suffix(2)) | |||
|
|
|||
| #if _runtime(_ObjC) | |||
There was a problem hiding this comment.
I'm not sure why all these substring tests are guarded under _runtime(_ObjC). Is that a mistake, @milseman?
There was a problem hiding this comment.
The only reason would be if they exercised grapheme breaking that the oldest Ubuntu LTS didn't support
There was a problem hiding this comment.
(in which case availability would be a better tool for this)
|
I don't want to make these changes without review, but feel free to merge them while I'm gone if there are no problems. |
itaiferber
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests aren't all passing yet on Mac OS X 10.9, but this takes care of a bunch of the easy ones. The remaining ones are:
(validation)