Skip to content

[stdlib] Additional ownership annotations #19706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

airspeedswift
Copy link
Member

What it says...

@airspeedswift
Copy link
Member Author

@swift-ci please smoke benchmark

@airspeedswift
Copy link
Member Author

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 4, 2018

Build comment file:

Performance: -O

TEST OLD NEW DELTA RATIO
Regression
RemoveWhereFilterStrings 435 512 +17.7% 0.85x
RemoveWhereFilterString 238 257 +8.0% 0.93x
LazilyFilteredArrayContains 33417 35943 +7.6% 0.93x
Improvement
ObjectiveCBridgeFromNSArrayAnyObject 31007 26159 -15.6% 1.19x

Code size: -O

TEST OLD NEW DELTA RATIO
Improvement
LazyFilter.o 11474 9762 -14.9% 1.18x

Performance: -Osize

TEST OLD NEW DELTA RATIO
Regression
RemoveWhereFilterStrings 435 514 +18.2% 0.85x
Array2D 11998 13194 +10.0% 0.91x
Improvement
CStringLongAscii 3547 3296 -7.1% 1.08x

Performance: -Onone

TEST OLD NEW DELTA RATIO
Improvement
RangeAssignment 4155 3326 -20.0% 1.25x

Code size: Swift libraries

TEST OLD NEW DELTA RATIO
Regression
libswiftSwiftOnoneSupport.dylib 221184 225280 +1.9% 0.98x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@airspeedswift
Copy link
Member Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Oct 4, 2018

Build comment file:

Performance: -O

TEST OLD NEW DELTA RATIO
Regression
RemoveWhereFilterStrings 433 511 +18.0% 0.85x
Improvement
CStringLongAscii 3541 3288 -7.1% 1.08x

Code size: -O

TEST OLD NEW DELTA RATIO
Improvement
LazyFilter.o 11474 9762 -14.9% 1.18x

Performance: -Osize

TEST OLD NEW DELTA RATIO
Regression
RemoveWhereFilterStrings 435 511 +17.5% 0.85x
Array2D 11998 13194 +10.0% 0.91x
Improvement
CStringLongAscii 3558 3310 -7.0% 1.07x

Code size: Swift libraries

TEST OLD NEW DELTA RATIO
Regression
libswiftSwiftOnoneSupport.dylib 221184 225280 +1.9% 0.98x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@@ -1490,7 +1490,7 @@ extension Array {
}

@inlinable
public func _copyContents(
__consuming public func _copyContents(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public __consuming?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gah, thx

@airspeedswift
Copy link
Member Author

@swift-ci please smoke test and merge

1 similar comment
@airspeedswift
Copy link
Member Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit dfed279 into swiftlang:master Oct 4, 2018
@airspeedswift airspeedswift deleted the further-pwnage branch October 4, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants