IRGen type lowering cleanup #19723
Merged
IRGen type lowering cleanup #19723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few utility methods would bypass computing the TypeInfo for a tuple, but they were only used in assertions or used in places where I can't imagine tuples coming up often enough for it to matter.
This was an old workaround for a bug that should no longer happen now that convenience initializers only have allocating entry points.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
I think the idea with the forward-declarations was to make sure that self-references got a nice type during lowering. But I don't really know why that would be important anymore, honestly, since none of our valid recursion cases needs that type — e.g. we don't have well-typed pointers at the SIL level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the YAML type info deserialization logic I cleaned up some code in this area.