[sil] Split operand ownership classification from SILOwnershipVerifie… #19732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
atrick
reviewed
Oct 9, 2018
…r.cpp into OperandOwnership.cpp. Last week I split out operand ownership classification from the SILOwnershipVerifier into the OperandOwnershipKindClassifier. Now move that classifier code to another file so that SILOwnershipVerifier.cpp just consists of the actual checker code. This makes sense since this type of classifier is describing a separate structural aspect of SIL rather than something intrinsic to the ownership verifier. Keep in mind that this is not the final form of this classifier. Just an incremental step forward.
gottesmm
force-pushed
the
pr-66a523eae15afbe54d55ad162517c83806096dee
branch
from
ec435a3 to
1baf38c
Compare
|
@swift-ci smoke test and merge |
4 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
Linux failure def isn't mine (looks like typechecker error?) |
|
@swift-ci smoke test linux platform |
1 similar comment
|
@swift-ci smoke test linux platform |
|
llbuild failure I don't think it is mine... |
|
@swift-ci smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r.cpp into Operand.cpp.
Last week I split out operand ownership classification from the
SILOwnershipVerifier into the OperandOwnershipKindClassifier. Now move that
classifier code to another file so that SILOwnershipVerifier.cpp just consists
of the actual checker code. This makes sense since this type of classifier is
describing a separate structural aspect of SIL rather than something intrinsic
to the ownership verifier.
Keep in mind that this is not the final form of this classifier. Just an
incremental step forward.
This is just a manual move.