Windows stdlib #19739
Merged
Windows stdlib #19739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this header is used to create a module, it is used in a "C" environment, which means that we cannot use the C++ style casts. Switch to the old-style-cast. If we need to, we can always use `-Wno-old-style-casts` to silence the warnings in C++ mode.
`ssize_t` is not available on Windows. We have an internal type definition `__swift_ssize_t` which allows us to use the type. Switch to that spelling.
The system header depends on Windows.h but does not include it itself. This results in base Windows types (e.g. ULONG) to be undefined. Include the header to include the needed typedefs.
On Windows the filesystem is not case sensitive and this will link just fine. However, the Windows SDK provides the import library with the lowercase name. Adjust the name so that the link actually succeeds on case-sensitive file systems (like on Linux). This fixes the Windows cross-compile.
|
CC: @mikeash |
|
@swift-ci please test |
|
Thank you for cleaning up my mess again. 😄 😢 Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.